Diablo mail application bug?

Hi,

If, in the built in maill app (I know it's got a name, can't remember
right now) I edit a reply to a mail and accidently hit Ctrl-W or Close
Window the dialog "Save changes" is presented with two options: "Save"
and "Cancel". Hitting "Save" saves the message as a draft (as
expected). I would assume that hitting "Cancel" would cancel the close
operation. Instead it cancels the save operation and closes the window
without saving changes. IMHO the button should be renamed or the
action should be changed to cancelling the close operation.

best

Henrik Frisk

On Wed, Nov 19, 2008 at 12:00:40PM +0100, Henrik Frisk wrote:
> If, in the built in maill app (I know it's got a name, can't remember
> right now)

Modest.

> I edit a reply to a mail and accidently hit Ctrl-W or Close
> Window the dialog "Save changes" is presented with two options: "Save"
> and "Cancel". Hitting "Save" saves the message as a draft (as
> expected). I would assume that hitting "Cancel" would cancel the close
> operation. Instead it cancels the save operation and closes the window
> without saving changes. IMHO the button should be renamed or the
> action should be changed to cancelling the close operation.

There should be three buttons.

'Save draft and close', 'Close without saving', 'Continue editing'

Marius Gedminas
--
I noticed that Open Source proponents using MacOS X have developed highly tuned
excuses, similar to those that smokers have about why cigarettes are good for
you.
-- Miguel de Icaza,
http://primates.ximian.com/~miguel/archive/2004/Aug-03.html

Hi Henrik, Marius,

> -----Original Message-----
> From: maemo-users-bounces@maemo.org
> [mailto:maemo-users-bounces@maemo.org] On Behalf Of ext

> On Wed, Nov 19, 2008 at 12:00:40PM +0100, Henrik Frisk wrote:
> > If, in the built in maill app (I know it's got a name,
> can't remember
> > right now)
>
> Modest.
>
> > I edit a reply to a mail and accidently hit Ctrl-W or Close
> > Window the dialog "Save changes" is presented with two
> options: "Save"
> > and "Cancel". Hitting "Save" saves the message as a draft (as
> > expected). I would assume that hitting "Cancel" would
> cancel the close
> > operation. Instead it cancels the save operation and closes
> the window
> > without saving changes. IMHO the button should be renamed or the
> > action should be changed to cancelling the close operation.
>
> There should be three buttons.
>
> 'Save draft and close', 'Close without saving', 'Continue editing'

In general, I like the more informative, GNOME-style buttons as you
propose; however, there are two issues:

i) changing the ok/cancel to these more explicit titles would be
inconsistent with the rest of the UI. I don't necessarily always
agree with the UI consistency-über-alles rule, but it's an uphill
battle to change that. Even having three button is too 'diverse'...

ii) even in english, the names are quite long; in many other languages
these longer names may not fit on the screen.

However, I agree that 'Cancel' is misleading here. But at least, after
loosing your mail once, one will not forget...

Maybe we should add a 'Mu'[1] button, which would 'unask the question'...

Best wishes,
Dirk.

[1] http://www.catb.org/jargon/html/M/mu.html

On Wed, Nov 19, 2008 at 1:34 PM, <Dirk-Jan.Binnema@nokia.com> wrote:
> Hi Henrik, Marius,
>
>> -----Original Message-----
>> From: maemo-users-bounces@maemo.org
>> [mailto:maemo-users-bounces@maemo.org] On Behalf Of ext
>
>> On Wed, Nov 19, 2008 at 12:00:40PM +0100, Henrik Frisk wrote:
>> > If, in the built in maill app (I know it's got a name,
>> can't remember
>> > right now)
>>
>> Modest.
>>

[snip]

>> There should be three buttons.
>>
>> 'Save draft and close', 'Close without saving', 'Continue editing'
>
> In general, I like the more informative, GNOME-style buttons as you
> propose; however, there are two issues:
>
> i) changing the ok/cancel to these more explicit titles would be
> inconsistent with the rest of the UI. I don't necessarily always
> agree with the UI consistency-über-alles rule, but it's an uphill
> battle to change that. Even having three button is too 'diverse'...
>
(Search (ctrl-E in Modest) presents three buttons...)
Problem to me is that the 'Cancel' button doesn't cancel the operation
that initiated the dialog: the closing of the window. I'm not going to
make this a big issue but I find it really confusing although I can
see the driving force behind it is consistency. Even hitting the right
button (that is, "OK") forces the user to change folder and reopen the
mail.

I may be wrong here (I'm no UI guru) but aren't these kinds of dialogs
usually addressing the issue negatively:

"Are you sure you want to disregard changes?"

Then the two choices "OK" and "Cancel" would make more sense to me;
cancelling would take you back to your message giving you the chance
to save your draft before closing the window.

> ii) even in english, the names are quite long; in many other languages
> these longer names may not fit on the screen.
>
> However, I agree that 'Cancel' is misleading here. But at least, after
> loosing your mail once, one will not forget...
>
I'm not going to argue that I'm representative, but I don't seem to
learn at all. I use emacs for most of my work and ctrl-W means
something else there. As a result I unintentionally close windows
quite often. And I intentinally click "Cancel" every time thinking
it's the right thing to do...

I thought it was a mistake, but if it isn't, I'll try to learn!

best,

Henrik

Hi Henrik,

> -----Original Message-----
> From: ext Henrik Frisk [mailto:frisk.h@gmail.com]

> >> Modest.
> >>
>
> [snip]
>
> >> There should be three buttons.
> >>
> >> 'Save draft and close', 'Close without saving',
> 'Continue editing'

> (Search (ctrl-E in Modest) presents three buttons...)
> Problem to me is that the 'Cancel' button doesn't cancel the operation
> that initiated the dialog: the closing of the window. I'm not going to
> make this a big issue but I find it really confusing although I can
> see the driving force behind it is consistency. Even hitting the right
> button (that is, "OK") forces the user to change folder and reopen the
> mail.

I agree that 'Cancel' is confusing here; but as I explained, inertia is
quite high. Which is not to say that we shouldn't try to improve this.

> > ii) even in english, the names are quite long; in many
> other languages
> > these longer names may not fit on the screen.
> >
> > However, I agree that 'Cancel' is misleading here. But at
> least, after
> > loosing your mail once, one will not forget...
> >
> I'm not going to argue that I'm representative, but I don't seem to
> learn at all. I use emacs for most of my work and ctrl-W means
> something else there. As a result I unintentionally close windows
> quite often. And I intentinally click "Cancel" every time thinking
> it's the right thing to do...

Hmmm... maybe cua-mode would be good for you?

> I thought it was a mistake, but if it isn't, I'll try to learn!

good luck!

best wishes,
Dirk.