Todo List

Group DBusAuth

some SASL profiles require sending the empty string as a challenge/response, but we don't currently allow that in our protocol.

Group DBusAuth

right now sometimes both ends will block waiting for input from the other end, e.g. if there's an error during DBUS_COOKIE_SHA1.

Group DBusAuth

the cookie keyring needs to be cached globally not just per-auth (which raises threadsafety issues too)

Group DBusAuth

grep FIXME in dbus-auth.c

Global _dbus_auth_decode_data

1.0? We need to be able to distinguish "out of memory" error from "the data is hosed" error.

Group DBusBus

right now the default address of the system bus is hardcoded, so if you change it in the global config file suddenly you have to set DBUS_SYSTEM_BUS_ADDRESS env variable. Might be nice if the client lib somehow read the config file, or if the bus on startup somehow wrote out its address to a well-known spot, but might also not be worth it.

Global dbus_connection_add_filter

we don't run filters on messages while blocking without entering the main loop, since filters are run as part of dbus_connection_dispatch(). This is probably a feature, as filters could create arbitrary reentrancy. But kind of sucks if you're trying to filter METHOD_RETURN for some reason.

Global dbus_connection_dispatch

some FIXME in here about handling DBUS_HANDLER_RESULT_NEED_MEMORY

Global dbus_connection_get_windows_user

We would like to be able to say "You can ask the bus to tell you the user of another connection though if you like; this is done with dbus_bus_get_windows_user()." But this has to be implemented in bus/driver.c and dbus/dbus-bus.c, and is pointless anyway since on Windows we only use the session bus for now.

Global dbus_connection_set_watch_functions

We need to drop the lock when we call the add/remove/toggled functions which can be a side effect of setting the watch functions.

Global _dbus_connection_block_pending_call

could use performance improvements (it keeps scanning the whole message queue for example)

Global _dbus_connection_handle_watch

This is basically a hack - we could delete _dbus_transport_handle_watch() and the virtual handle_watch in DBusTransport if we got rid of it. The reason this is some work is threading, see the _dbus_connection_handle_watch() implementation.

Global _dbus_credentials_add_from_user

this is broken because it treats OOM and parse error the same way. Needs a DBusError.

Global _dbus_error_from_errno

should cover more errnos, specifically those from open().

Group DBusKeyring

there's a memory leak on some codepath in here, I saw it once when running make check - probably some specific initial cookies present in the cookie file, then depending on what we do with them.

Global _dbus_keyring_validate_context

this is the most inefficient implementation imaginable.

Global _dbus_type_reader_delete

for now this does not delete the typecodes associated with the value, so this function should only be used for array elements.

Global _dbus_type_reader_set_basic

DBusTypeReader currently takes "const" versions of the type and value strings, and this function modifies those strings by casting away the const, which is of course bad if we want to get picky. (To be truly clean you'd have an object which contained the type and value strings and set_basic would be a method on that object... this would also make DBusTypeReader the same thing as DBusTypeMark. But since DBusMessage is effectively that object for D-Bus it doesn't seem worth creating some random object.)

Global _dbus_type_reader_set_basic

optimize this by only rewriting until the old and new values are at the same alignment. Frequently this should result in only replacing the value that's immediately at hand.

Global _dbus_validate_bus_name

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_error_name

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_interface

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_member

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_path

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_path

change spec to disallow more things, such as spaces in the path name

Global _dbus_validate_signature

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global DBusMessageLoader

write tests for break-loader that a) randomly delete header fields and b) set string fields to zero-length and other funky values.

Global _dbus_message_loader_get_buffer

this function can be a lot more clever. For example it can probably always return a buffer size to read exactly the body of the next message, thus avoiding any memory wastage or reallocs.

Global _dbus_message_loader_get_buffer

we need to enforce a max length on strings in header fields.

Global _dbus_message_loader_queue_messages

we need to check that the proper named header fields exist for each message type.

Global _dbus_message_loader_queue_messages

If a message has unknown type, we should probably eat it right here rather than passing it out to applications. However it's not an error to see messages of unknown type.

Global INITIAL_LOADER_DATA_LEN

this should be based on min header size plus some average body size, or something. Or rather, the min header size only, if we want to try to read only the header, store that in a DBusMessage, then read only the body and store that, etc., depends on how we optimize _dbus_message_loader_get_buffer() and what the exact message format is.

Global dbus_message_append_args

support DBUS_TYPE_STRUCT and DBUS_TYPE_VARIANT and complex arrays

Global dbus_message_append_args

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_append_args_valist

for now, if this function fails due to OOM it will leave the message half-written and you have to discard the message and start over.

Global dbus_message_get_args

support DBUS_TYPE_STRUCT and DBUS_TYPE_VARIANT and complex arrays

Global dbus_message_get_path_decomposed

this could be optimized by using the len from the message instead of calling strlen() again

Global dbus_message_iter_append_basic

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_append_fixed_array

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_close_container

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_get_array_len

introduce a variant of this get_n_elements that returns the number of elements, though with a non-fixed array it will not be very efficient, so maybe it's not good.

Global dbus_message_iter_init_append

If appending any of the arguments fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_open_container

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_new_error_printf

add _DBUS_GNUC_PRINTF to this (requires moving _DBUS_GNUC_PRINTF to public header, see DBUS_DEPRECATED for an example)

Global _dbus_object_tree_dispatch_and_unlock

thread problems

Global dbus_pending_call_block

when you start blocking, the timeout is reset, but it should really only use time remaining since the pending call was created. This requires storing timestamps instead of intervals in the timeout

Group DBusServer

Thread safety hasn't been tested much for DBusServer

Group DBusServer

Need notification to apps of disconnection, may matter for some transports

Group DBusString

DBusString needs a lot of cleaning up; some of the API is no longer used, and the API is pretty inconsistent. In particular all the "append" APIs, especially those involving alignment but probably lots of them, are no longer used by the marshaling code which always does "inserts" now.

Global _dbus_string_ends_with_c_str

memcmp might make this faster.

Global _dbus_string_equal

memcmp is probably faster

Global _dbus_string_equal_substring

write a unit test

Global _dbus_string_equal_substring

memcmp is probably faster

Global _dbus_string_move_len

this doesn't do anything with max_length field. we should probably just kill the max_length field though.

Global _dbus_string_pop_line

owen correctly notes that this is a stupid function (it was written purely for test code, e.g. dbus-message-builder.c). Probably should be enforced as test code only with ifdef DBUS_BUILD_TESTS

Global _dbus_string_replace_len

optimize the case where the two lengths are the same, and avoid memmoving the data in the trailing part of the string twice.

Global _dbus_string_replace_len

avoid inserting the source into dest, then deleting the replaced chunk of dest (which creates a potentially large intermediate string). Instead, extend the replaced chunk of dest with padding to the same size as the source chunk, then copy in the source bytes.

Global _dbus_string_validate_ascii

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_string_validate_nul

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_string_validate_utf8

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global DBusGUID

rename to UUID instead of GUID

Global _dbus_atomic_dec

implement arch-specific faster atomic ops

Global _dbus_atomic_inc

implement arch-specific faster atomic ops

Global _dbus_concat_dir_and_file

it might be cute to collapse multiple '/' such as "foo//" concat "//bar"

Global _dbus_full_duplex_pipe

libdbus only uses this for the debug-pipe server, so in principle it could be in dbus-sysdeps-util.c, except that dbus-sysdeps-util.c isn't in libdbus when tests are enabled and the debug-pipe server is used.

Global _dbus_open_tcp_socket

Use for the file descriptors a struct

• struct DBusSocket{ int d; }; - instead of int to get type-safety which will be checked by the compiler.

Global _dbus_transport_new_for_domain_socket

once we add a way to escape paths in a dbus address, this function needs to do escaping.

Global _dbus_transport_get_is_authenticated

we drop connection->mutex when calling the unix_user_function, and windows_user_function, which may not be safe really.

Global _dbus_watch_set_handler

this function only exists because of the weird way connection watches are done, see the note in docs for _dbus_connection_handle_watch().

---